Re: [PATCH] builtin/push.c: add push.pushOption config
From: Junio C Hamano <hidden>
Date: 2017-10-20 06:18:48
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2017-10-24 · Re: [PATCH] builtin/push.c: add push.pushOption config · Junio C Hamano <hidden>
- 2017-10-23 · [PATCH] builtin/push.c: add push.pushOption config · Marius Paliga <hidden>
- 2017-10-21 · Re: [PATCH] builtin/push.c: add push.pushOption config · Junio C Hamano <hidden>
- 2017-10-21 · Re: [PATCH] builtin/push.c: add push.pushOption config · Junio C Hamano <hidden>
- 2017-10-20 · Re: [PATCH] builtin/push.c: add push.pushOption config · Stefan Beller <hidden>
Junio C Hamano [off-list ref] writes:
Junio C Hamano [off-list ref] writes:quoted
quoted
We'd also want to document how push.pushOption works in Documentation/config.txt (that contains all the configs)Perhaps.Here is my attempt.
Another thing I noticed while we are around the area is that unlike all other options in git-push.txt page, this one forgets to say it always takes mandatory string. Here is a possible fix. Documentation/git-push.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
index aa78057dc5..a8504e0ae3 100644
--- a/Documentation/git-push.txt
+++ b/Documentation/git-push.txt@@ -156,12 +156,12 @@ already exists on the remote side. Either all refs are updated, or on error, no refs are updated. If the server does not support atomic pushes the push will fail. --o:: ---push-option:: +-o <option>:: +--push-option=<option>:: Transmit the given string to the server, which passes them to the pre-receive as well as the post-receive hook. The given string must not contain a NUL or LF character. - When no `--push-option <option>` is given from the command + When no `--push-option=<option>` is given from the command line, the values of configuration variable `push.pushOption` are used instead.