Thread (3 messages) flat view 3 messages, 3 authors, 2017-10-18

Re: [PATCH 3/3] check-ref-format doc: --branch validates and expands <branch>

From: Jonathan Nieder <hidden>
Date: 2017-10-17 21:06:16

Junio C Hamano wrote:
Jonathan Nieder [off-list ref] writes:
quoted
From: Junio C Hamano <redacted>

"git check-ref-format --branch $name" feature was originally
introduced (and was advertised) as a way for scripts to take any
end-user supplied string (like "master", "@{-1}" etc.) and see if it
is usable when Git expects to see a branch name, and also obtain the
concrete branch name that the at-mark magic expands to.

Emphasize that "see if it is usable" role in the description and
clarify that the @{...} expansion only occurs when run from within a
repository.

[jn: split out from a larger patch]

Helped-by: Jeff King [off-list ref]
Signed-off-by: Junio C Hamano <redacted>
---
Missing sign-off, unlike the other two, intended?
Oops.
Signed-off-by: Jonathan Nieder <redacted>
I'll take these three to replace what I tentatively queued, not
necessarily because I like the change in 1/3 better, but because
these are explained much better; besides I prefer a version that at
least two people deeply looked at.
Okay, thanks.  I'll add the rest of the change as a patch on top. :)

Thanks,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help