Re: [PATCH v5 0/4] Improve abbreviation disambiguation

On Thu, Oct 12, 2017 at 09:21:15PM +0900, Junio C Hamano wrote:

Derrick Stolee [off-list ref] writes:

quoted

On 10/12/2017 8:02 AM, Derrick Stolee wrote:

quoted

Changes since previous version:

* Make 'pos' unsigned in get_hex_char_from_oid()

* Check response from open_pack_index()

* Small typos in commit messages

Thanks,
  Stolee

I forgot to mention that I rebased on master this morning to be sure
this doesn't conflict with the binary-search patch that was queued
this week.

Thanks for being extra careful.  

I've re-applied minor style fix s/(void\*)/(void \*)/ to 2/4 and 4/4
but other than that, the difference between this round and what has
been queued looked all reasonable.

Will replace.

This looks good to me, too.

At first I was going to point out the nit that unique_in_pack() is
quietly fixed in 4/4 for the empty-pack case. But I don't think it's
actually buggy. The examination of nth_packed_object_oid() would never
be triggered if "num" is 0. So it probably is fine simply to fix it
quietly along with adding the new function.

-Peff