Special strings in commit messages
From: Florian Weimer <hidden>
Date: 2017-10-08 18:24:45
Subsystem:
the rest · Maintainer:
Linus Torvalds
I have a commit which looks like this: $ git cat-file commit 4ca76eb7b47724c2444dfea7890fa8db4edd5762 tree c845be47a0653624b1984d0dc1a0b485b527811d parent 9eee98638ef06149e17f94afaa357e3a9e296e69 author Florian Weimer [off-list ref] 1507481682 +0200 committer Florian Weimer [off-list ref] 1507481682 +0200 19: glibc-fedora-nis-rh188246.patch From baba5d9461d4e8a581ac26fe4412ad783ffc73e7 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek <redacted> Date: Mon, 1 May 2006 08:02:53 +0000 Subject: [PATCH] Enable SETENT_BATCH_READ nis/nss option by default * Mon May 1 2006 Jakub Jelinek [off-list ref] 2.4.90-4 - SETENT_BATCH_READ /etc/default/nss option for speeding up some usages of NIS+ (#188246) This commit causes git rebase to fail, with this error: fatal: could not parse .git/rebase-apply/0008 At this point, .git/rebase-apply/0008 contains this: “ From baba5d9461d4e8a581ac26fe4412ad783ffc73e7 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek <redacted> Date: Mon, 1 May 2006 08:02:53 +0000 Subject: [PATCH] Enable SETENT_BATCH_READ nis/nss option by default * Mon May 1 2006 Jakub Jelinek [off-list ref] 2.4.90-4 - SETENT_BATCH_READ /etc/default/nss option for speeding up some usages of NIS+ (#188246) --- nis/nss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nis/nss b/nis/nssindex 0ac6774a1ff29f012efaec9c4be1fcc3b83da7e8..d720e719267db5f741b67e7b98e4052e503c4333 100644 ” Followed by the diff. The preceding patch, .git/rebase-apply/0007, is: “ [fweimer@oldenburg glibc-patches]$ cat .git/rebase-apply/0007 From 4ca76eb7b47724c2444dfea7890fa8db4edd5762 Mon Sep 17 00:00:00 2001 From: Florian Weimer <redacted> Date: Sun, 8 Oct 2017 18:54:42 +0200 Subject: 19: glibc-fedora-nis-rh188246.patch ” Based on strace output, something in git rebase calls git mailsplit, and it probably sees the "\nFrom " string and treats it as a start of a new mail message, and things go downhill from there. I will escape "\nFrom " in commit messages (probably as "\n.From " or maybe "\n>From ", plus escaping for "\n."/"\n>" to make the encoding reversible), but I wonder if there is something else I need to escape while I'm at it. Thanks, Florian