Thread (1 message) 1 message, 1 author, 2017-10-03

Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun

From: Junio C Hamano <hidden>
Date: 2017-10-03 04:12:15

Jonathan Nieder [off-list ref] writes:
Ann T Ropea wrote:
quoted
Of the many ways to spell the three-letter word, the variant "Git"
should be used when referring to a repository in a description; or, in
general, when it is used as a proper noun.

We thus change the pull-request template message so that it reads

   "...in the Git repository at:"

Besides, this brings us in line with the documentation, see
Documentation/howto/using-signed-tag-in-pull-request.txt

Signed-off-by: Ann T Ropea <redacted>
Acked-by: Jonathan Nieder <redacted>
---
v2: rename patch, correct Signed-off-by line, add Acked-by line
 git-request-pull.sh     | 2 +-
 t/t5150-request-pull.sh | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Jonathan Nieder <redacted>

Thanks for the quick turnaround.
Thanks, but the patch is whitespace damaged and did not apply (what
happend to "reviewer's oversight statement" ;-).

As there were only three instances, I just edited the target files
and committed, which was far quicker than trying to match
whitespaces by editing the patch text.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help