Thread (1 message) 1 message, 1 author, 2017-10-02

Re: [PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom

From: Junio C Hamano <hidden>
Date: 2017-10-02 09:52:16

Jeff King [off-list ref] writes:
quoted
 		atom->u.contents.option = C_SUB;
-	else if (!strcmp(arg, "trailers"))
-		atom->u.contents.option = C_TRAILERS;
-	else if (skip_prefix(arg, "lines=", &arg)) {
+	else if (skip_prefix(arg, "trailers", &arg)) {
+		skip_prefix(arg, ":", &arg);
+		trailers_atom_parser(format, atom, *arg ? NULL : arg);
I think your logic is flipped. You want "*arg ? arg : NULL";
Ahh, I was blind.  Will fix locally and push the results out.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help