Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h
From: Оля Тележная <hidden>
Date: 2017-10-02 09:38:00
quoted
Simplify mru.[ch] and related code by reusing the double-linked list implementation from list.h instead of a custom one. This commit is an intermediate step. Our final goal is to get rid of mru.[ch] at all and inline all logic.Thanks, this version looks correct to me.
Great! What is better - to complete my application now (and say only about this patch) or to complete it in last days (and say about everything that I've done. Maybe there would be something new).
I do think there are a few ugly bits in the result (like that initializer for packed_git_mru :) ), so I'd prefer not to merge this down until we do that final step. So the big question is: who wants to do it? I think you've done a good job here, and this would count for your Outreachy application's contribution. But if you'd like to do that next step, you are welcome to.
I was thinking about starting my small research about main task of the internship. I could postpone it and end with this task, there's no problem for me. Or, if someone from the newbies wants to have a small simple task - it's a great opportunity for him/her. By the way, I am ready to help if he/she will have questions or difficulties. So please make a decision on your own, I will be happy in any scenario.