Re: [PATCH v5 6/6] ref-filter.c: parse trailers arguments with %(contents) atom
From: Junio C Hamano <hidden> Date: 2017-10-02 04:26:29
Taylor Blau [off-list ref] writes:
A caveat: trailers_atom_parser expects NULL when no arguments are given
(see: `parse_ref_filter_atom`). This is because string_list_split (given
a maxsplit of -1) returns a 1-ary string_list* containing the given
string if the delimiter could not be found using `strchr`.
OK. That's unfortunate, but the solution here is far cleaner and
simpler than fixing string-list-split. Thanks for an updated
explanation here.