RE: [PATCH v8 00/12] Fast git status via a file system watcher

-----Original Message-----
From: Junio C Hamano [mailto:gitster@pobox.com]
Sent: Thursday, September 28, 2017 10:21 PM
To: Ben Peart <redacted>
Cc: David.Turner@twosigma.com; avarab@gmail.com;
christian.couder@gmail.com; git@vger.kernel.org;
johannes.schindelin@gmx.de; pclouds@gmail.com; peff@peff.net
Subject: Re: [PATCH v8 00/12] Fast git status via a file system watcher

Ben Peart [off-list ref] writes:

quoted

The only behavioral change from V7 is the removal of unnecessary uses
of CE_MATCH_IGNORE_FSMONITOR.  With a better understanding of

*why*

quoted

the
CE_MATCH_IGNORE_* flags are used, it is now clear they are not
required in most cases where CE_MATCH_IGNORE_FSMONITOR was being
passed out of an abundance of caution.

The reviews and updates after this round was posted were to

 * 01/12 had an obvious pointer-vs-pointee thinko, which I think I
   have locally fixed;

 * 08/12 forgot to add a new test executable to .gitignore file,
   which I think I have locally fixed, too.

Any other review comments and suggestions for improvements?
Otherwise I am tempted to declare victory and merge this to 'next'
soonish.

For reference, here is the interdiff between what was posted as v8 and what
I have on 'pu'.

I had accumulated the same set of changes with one addition of removing
a duplicate "the" from a comment in the fsmonitor.h file:

diff --git a/fsmonitor.h b/fsmonitor.h
index 8eb6163455..0de644e01a 100644
--- a/fsmonitor.h
+++ b/fsmonitor.h

@@ -4,7 +4,7 @@
 extern struct trace_key trace_fsmonitor;
 
 /*
- * Read the the fsmonitor index extension and (if configured) restore the
+ * Read the fsmonitor index extension and (if configured) restore the
  * CE_FSMONITOR_VALID state.
  */
 extern int read_fsmonitor_extension(struct index_state *istate, const void *data, unsigned long sz);