Thread (2 messages) flat view 2 messages, 2 authors, 2017-09-27

Re: [PATCH v2 6/9] connect: teach client to recognize v1 server response

From: Junio C Hamano <hidden>
Date: 2017-09-27 01:07:34

Brandon Williams [off-list ref] writes:
+/* Returns 1 if packet_buffer is a protocol version pkt-line, 0 otherwise. */
+static int process_protocol_version(void)
+{
+	switch (determine_protocol_version_client(packet_buffer)) {
+		case protocol_v1:
+			return 1;
+		case protocol_v0:
+			return 0;
+		default:
+			die("server is speaking an unknown protocol");
+	}
+}
checkpatch.pl yells at me:

    ERROR: switch and case should be at the same indent

and we would probably want to teach "make style" the same, if we
already don't.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help