Thread (4 messages) flat view 4 messages, 3 authors, 2017-09-26

Re: [PATCH] t7406: submodule.<name>.update command must not be run from .gitmodules

From: Junio C Hamano <hidden>
Date: 2017-09-26 06:28:29

Possibly related (same subject, not in this thread)

Johannes Sixt [off-list ref] writes:
quoted
+	test_when_finished "git -C super reset --hard HEAD^" &&
+
+	write_script must_not_run.sh <<-EOF &&
+	>$TEST_DIRECTORY/bad
+	EOF
I am pretty confident that this does not test what you intend to
test. Notice that $TEST_DIRECTORY is expanded when the script is
written. But that path contains a blank, and we have something like
this in the test script:

	#!/bin/sh
	>/the/build/directory/t/trash directory.t7406/bad
Nicely explained.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help