Thread (1 message) 1 message, 1 author, 2017-09-22

Re: [PATCH 2/4] test-line-buffer: simplify command parsing

From: Junio C Hamano <hidden>
Date: 2017-09-22 03:47:42

Jeff King [off-list ref] writes:
However, each case arm of the switch falls through to the
one below it. This is pointless (we know that a command
starting with 'b' does not need to check any of the commands
in the 'c' block), and it makes gcc's -Wimplicit-fallthrough
complain.
Wow, this is an embarassment. The code tries to cleverly optimize
it, and then fails miserably.

The updated one reads good.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help