Thread (1 message) 1 message, 1 author, 2017-09-22

Re: [PATCH v1] travis-ci: fix "skip_branch_tip_with_tag()" string comparison

From: Junio C Hamano <hidden>
Date: 2017-09-22 01:57:42

Lars Schneider [off-list ref] writes:
Oh, you're right!

quoted
Could you squash in the following?
@Junio: Can you squash it when you apply the patch?
I do not mind and I already did.

The patches in the series this patch is fixing up were solely about
splitting these scripts out of the YAML file as-is, and I think it
was correct to carry these style differences over without adjusting
them.

But resulting scripts in ci/ are riddled with styleguide deviations,
which may want to be cleaned up later.  There also are some
bash-isms marked with "#!env bash" in them, but I think they are OK
because we know we are running them only at a very specific place
and the need to make them portable is very small.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help