Thread (33 messages) 33 messages, 6 authors, 2017-09-19

Re: [PATCH for jk/leak-checkers] git-compat-util: make UNLEAK less error-prone

flat view

From: Jeff King <hidden>
Date: 2017-09-19 21:46:15

On Tue, Sep 19, 2017 at 02:34:56PM -0700, Jonathan Tan wrote:
Commit 0e5bba5 ("add UNLEAK annotation for reducing leak false
positives", 2017-09-08) introduced an UNLEAK macro to be used as
"UNLEAK(var);", but its existing definitions make it possible to be
invoked as "UNLEAK(var)" (without the trailing semicolon) too.

Therefore, modify its definitions to cause a compile-time error if
invoked without the trailing semicolon.
The patch itself looks good, but I think your commit message dances
around the real motivation: some parsers may complain about doubled
semicolons, or semicolons without an associated line of code (which is
really just a doubled semicolon, too, I guess).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help