Thread (1 message) 1 message, 1 author, 2017-09-15

Re: [PATCH v4 3/4] imap_send: setup_curl: retreive credentials if not set in config file

From: Junio C Hamano <hidden>
Date: 2017-09-15 04:44:22

Nicolas Morey-Chaisemartin [off-list ref] writes:
+	if (cred.username)
+		if (res == CURLE_OK)
+			credential_approve(&cred);
+#if LIBCURL_VERSION_NUM >= 0x070d01
+		else if (res == CURLE_LOGIN_DENIED)
A slight tangent.  This is in line with the way in which we do
conditional compilation to work with different versions of libCurl,
but we recently had discussion on modernizing these version based
conditional compilation to use feature based one in another topic.
We may want to switch to

	#if defined(CURLE_LOGIN_DENIED)
		...

(cf.
https://public-inbox.org/git/cover.1502462884.git.tgc@jupiterrise.com/
the entire thread).

No need to change _this_ patch in this series, but something to keep
in mind planning for a future follow-up work to clean things up.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help