Thread (1 message) 1 message, 1 author, 2017-09-10

Re: [PATCH 34/34] wt-status: release strbuf after use in wt_longstatus_print_tracking()

From: Junio C Hamano <hidden>
Date: 2017-09-10 07:40:05

René Scharfe [off-list ref] writes:
Am 06.09.2017 um 21:51 schrieb Junio C Hamano:
quoted
Rene Scharfe [off-list ref] writes:
quoted
If format_tracking_info() returns 0 only if it didn't touch its strbuf
parameter, so it's OK to exit early in that case.  Clean up sb in the
other case.
These two "if"s confuse me; perhaps the first one is not needed?
Yes, removing it looks like the best way to make that sentence clearer.
Another would be to replace "only if" with "then".
Either makes it understandable. Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help