Re: [PATCH 00/10] Implement transactions for the packed ref store

[PATCH 00/10] Implement transactions for the packed ref store · Michael Haggerty <hidden> · 2017-08-29
[PATCH 05/10] files_pack_refs(): use a reference transaction to write packed refs · Michael Haggerty <hidden> · 2017-08-29
[PATCH 04/10] packed_delete_refs(): implement method · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 04/10] packed_delete_refs(): implement method · Brandon Williams <hidden> · 2017-08-29
Re: [PATCH 04/10] packed_delete_refs(): implement method · Michael Haggerty <hidden> · 2017-08-30
[PATCH 06/10] files_initial_transaction_commit(): use a transaction for packed refs · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 06/10] files_initial_transaction_commit(): use a transaction for packed refs · Jeff King <hidden> · 2017-09-08
Re: [PATCH 06/10] files_initial_transaction_commit(): use a transaction for packed refs · Michael Haggerty <hidden> · 2017-09-08
[PATCH 07/10] t1404: demonstrate two problems with reference transactions · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions · Stefan Beller <hidden> · 2017-08-30
Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions · Michael Haggerty <hidden> · 2017-08-31
[PATCH 09/10] packed-backend: rip out some now-unused code · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 09/10] packed-backend: rip out some now-unused code · Brandon Williams <hidden> · 2017-08-29
[PATCH 08/10] files_ref_store: use a transaction to update packed refs · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 08/10] files_ref_store: use a transaction to update packed refs · Jeff King <hidden> · 2017-09-08
Re: [PATCH 08/10] files_ref_store: use a transaction to update packed refs · Michael Haggerty <hidden> · 2017-09-08
Re: [PATCH 08/10] files_ref_store: use a transaction to update packed refs · Jeff King <hidden> · 2017-09-08
[PATCH 10/10] files_transaction_finish(): delete reflogs before references · Michael Haggerty <hidden> · 2017-08-29
[PATCH 01/10] packed-backend: don't adjust the reference count on lock/unlock · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 01/10] packed-backend: don't adjust the reference count on lock/unlock · Jeff King <hidden> · 2017-09-08
Re: [PATCH 01/10] packed-backend: don't adjust the reference count on lock/unlock · Michael Haggerty <hidden> · 2017-09-08
[PATCH 02/10] struct ref_transaction: add a place for backends to store data · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 02/10] struct ref_transaction: add a place for backends to store data · Jeff King <hidden> · 2017-09-08
Re: [PATCH 02/10] struct ref_transaction: add a place for backends to store data · Michael Haggerty <hidden> · 2017-09-08
Re: [PATCH 02/10] struct ref_transaction: add a place for backends to store data · Jeff King <hidden> · 2017-09-08
[PATCH 03/10] packed_ref_store: implement reference transactions · Michael Haggerty <hidden> · 2017-08-29
Re: [PATCH 00/10] Implement transactions for the packed ref store · Brandon Williams <hidden> · 2017-08-29
Re: [PATCH 00/10] Implement transactions for the packed ref store · Jeff King <hidden> · 2017-09-08

From: Jeff King <hidden>
Date: 2017-09-08 07:43:08

On Tue, Aug 29, 2017 at 10:20:24AM +0200, Michael Haggerty wrote:

This should be the second-to-last patch series in the quest for
mmapped packed-refs.

I just gave this a careful read, and it looks pretty good to me. I had a
few questions, but no show-stoppers. I'll admit to glossing a little bit
over the conversions in patch 3 and 4, after seeing that they're
basically adaptations of the code that goes away in patch 9.

-Peff

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help