Re: [PATCH] hashmap: add API to disable item counting when threaded

On 9/5/2017 9:24 PM, Junio C Hamano wrote:

Jeff Hostetler [off-list ref] writes:

quoted

From: Jeff Hostetler <redacted>

I feel somewhat stupid to say this, especially after seeing many
people applaud this patch, but I do not seem to be able to even
build Git with this patch.  I am getting:

     common-main.o: In function `hashmap_get_size':
     /home/gitster/w/git.git/hashmap.h:260: multiple definition of `hashmap_get_size'
     fast-import.o:/home/gitster/w/git.git/hashmap.h:260: first defined here
     libgit.a(argv-array.o): In function `hashmap_get_size':
     /home/gitster/w/git.git/hashmap.h:260: multiple definition of `hashmap_get_size'
     fast-import.o:/home/gitster/w/git.git/hashmap.h:260: first defined here
     libgit.a(attr.o): In function `hashmap_get_size':
     ...

and wonder if others are building with different options or something..

That's odd. I'm not seeing that.  My Ubuntu VM is reporting:
     $ gcc --version
     gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005

I'll change it to static in the next version.  Hopefully that will
take care of it.

Thanks,
Jeff