Junio C Hamano [off-list ref] writes:
Ben Peart [off-list ref] writes:
quoted
quoted
- warning("external filter requested unsupported filter capability '%s'",
- p);
+ warning("subprocess '%s' requested unsupported capability '%s'",
+ process->argv[0], p);
}
}
This one is even cleaner. Thanks Lars for pointing out the fact we
already had the cmd name. Looks good.
Thanks, all. Will queue.
I still think we would want to turn warning() to die(), but it
probably is better to do so in a separate follow-up patch. That
will give us a good place to record the reason why the current "just
call a warning() and pretend as if nothing bad happend" is wrong.