Thread (1 message) 1 message, 1 author, 2017-08-16

Re: [PATCH v2] sub-process: print the cmd when a capability is unsupported

From: Junio C Hamano <hidden>
Date: 2017-08-16 21:55:48

Junio C Hamano [off-list ref] writes:
Ben Peart [off-list ref] writes:
quoted
quoted
-			warning("external filter requested unsupported filter capability '%s'",
-				p);
+			warning("subprocess '%s' requested unsupported capability '%s'",
+				process->argv[0], p);
  		}
  	}
  
This one is even cleaner.  Thanks Lars for pointing out the fact we
already had the cmd name.  Looks good.
Thanks, all.  Will queue.
I still think we would want to turn warning() to die(), but it
probably is better to do so in a separate follow-up patch.  That
will give us a good place to record the reason why the current "just
call a warning() and pretend as if nothing bad happend" is wrong.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help