Re: [PATCH 3/5] commit: replace the raw buffer with strbuf in read_graft_line

On Tue, Aug 15, 2017 at 7:02 PM, Stefan Beller [off-list ref] wrote:

quoted

        const int entry_size = GIT_SHA1_HEXSZ + 1;

outside the scope of this patch:
Is GIT_SHA1_HEXSZ or GIT_MAX_HEXSZ the right call here?

I think neither one. In my opinion, this code should not be so closely
coupled to hash parsing code - it should be tasked with parsing
whitespace separated list of commit ids without relying on specific
commit id length or format.

-- 
| ← Ceci n'est pas une pipe
Patryk Obara