Re: [PATCH] Convert size datatype to size_t

On Tue, Aug 08, 2017 at 11:04:20PM -0700, Junio C Hamano wrote:

Martin Koegler [off-list ref] writes:

quoted

From: Martin Koegler <redacted>

It changes the signature of the core object access function
including any other functions to assure a clean compile if
sizeof(size_t) != sizeof(unsigned long).

As https://travis-ci.org/git/git/jobs/262463159 shows, unfortunately
it turns out that things are not so simple X-<.  On Linux32, size_t
is uint, which is the same size as ulong, but "%lu" is not appropriate
for showing a size_t value.

So you are correct to say in the comment under three-dashes that
there is much more to change in the codebase.

My patch is based on V2 of my "Fix delta integer overflows" patch [also changing the variable types].

I'll post a new version fixing the *printf issues.

The patch can't be splitted without causing compile errors, if sizeof(size_t) != sizeof(ulong).
Many variables are not changed to keep the patch small.

Regards,
Martin