Re: [PATCH] builtin/add: add detail to a 'cannot chmod' error message
From: Junio C Hamano <hidden>
Date: 2017-08-09 05:45:38
Ramsay Jones [off-list ref] writes:
In addition to adding the missing newline, add the x-ecutable bit 'mode change' character to the error message. This message now has the same form as similar messages output by 'update-index'. Signed-off-by: Ramsay Jones <redacted> --- Hi Junio, This is v2 of the earlier "add a newline" patch. Thanks!
Thanks; here is me reminding myself to apply this with Jonathan's reviewed-by in the morning.
quoted hunk
ATB, Ramsay Jones builtin/add.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/builtin/add.c b/builtin/add.c index e888fb8c5..5d5773d5c 100644 --- a/builtin/add.c +++ b/builtin/add.c@@ -32,7 +32,7 @@ struct update_callback_data { int add_errors; }; -static void chmod_pathspec(struct pathspec *pathspec, int force_mode) +static void chmod_pathspec(struct pathspec *pathspec, char flip) { int i;@@ -42,8 +42,8 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode) if (pathspec && !ce_path_match(ce, pathspec, NULL)) continue; - if (chmod_cache_entry(ce, force_mode) < 0) - fprintf(stderr, "cannot chmod '%s'", ce->name); + if (chmod_cache_entry(ce, flip) < 0) + fprintf(stderr, "cannot chmod %cx '%s'\n", flip, ce->name); } }