Thread (2 messages) flat view 2 messages, 2 authors, 2017-08-07

Re: [PATCH] test-path-utils: handle const parameter of basename and dirname

From: Johannes Schindelin <hidden>
Date: 2017-08-07 21:15:13

Hi René,

On Mon, 7 Aug 2017, René Scharfe wrote:
The parameter to basename(3) and dirname(3) traditionally had the type
"char *", but on OpenBSD it's been "const char *" for years.  That
causes (at least) Clang to throw an incompatible-pointer-types warning
for test-path-utils, where we try to pass around pointers to these
functions.

Avoid this warning (which is fatal in DEVELOPER mode) by ignoring the
promise of OpenBSD's implementations to keep input strings unmodified
and enclosing them in POSIX-compatible wrappers.

Signed-off-by: Rene Scharfe <redacted>
---
This patch is Fine By Me.

Thanks,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help