Re: [PATCH] Drop some dashes from built-in invocations in scripts
From: Junio C Hamano <hidden>
Date: 2017-08-07 16:36:06
Michael Forney [off-list ref] writes:
This way, they still work even if the built-in symlinks aren't installed. Signed-off-by: Michael Forney <redacted> --- It looks like there was an effort to do this a number of years ago (through `make remove-dashes`). These are just a few I noticed were still left in the .sh scripts.
Our goal was *not* to have *no* "git-foo" on the filesystem, though. It happened in v1.6.0 timeframe and it was about removing "git-foo" from end-user's $PATH. Earlier there was a more ambitious proposal to remove all "git-foo" even from $GIT_EXEC_PATH for built-in commands, but that plan was scuttled [*1*]. The changes in your patch still are good changes to make sure people who copy & paste code would see fewer instances of "git-foo", but "will still work even if I break my installation of Git by removing them from the filesystem" is not the project's goal. IIUC, you will need "$GIT_EXEC_PATH/git-checkout" on the filesystem if you want your "git co" alias to work, as we spawn built-in as a dashed external. [Reference] *1* https://public-inbox.org/git/alpine.LFD.1.10.0808261114070.3363@nehalem.linux-foundation.org/