Thread (1 message) 1 message, 1 author, 2017-07-31

Re: [PATCH] hash: Allow building with the external sha1dc library

From: Junio C Hamano <hidden>
Date: 2017-07-31 22:28:25

Ævar Arnfjörð Bjarmason [off-list ref] writes:
So the upstream library expects you (and it's documented in their README) to do:

    #include <sha1dc/sha1.h>

But your patch is just doing:

    #include <sha1.h>

At best this seems like a trivial bug and at worst us encoding some
Suse-specific packaging convention in git, since other distros would
presumably want to package this in /usr/include/sha1dc/sha1.h as
upstream suggests. I.e. using the ambiguous sha1.h name is not
something upstream's doing by default, it's something you're doing in
your package.
It seems there still needs a bit more work on this patch.  Thanks
for reviewing and pointing out what needs to be addressed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help