Thread (25 messages) 25 messages, 3 authors, 2017-08-05

Re: [GSoC][PATCH 05/13] submodule: port submodule subcommand 'sync' from shell to C

From: Stefan Beller <hidden>
Date: 2017-07-31 21:19:10

On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan [off-list ref] wrote:
In this new version, the following changes have been made:
* There was no good reason for using puts in the function print_default_remote()
  Hence, in this patch, we instead use printf to do the same, as it is what
  is generally used throughout the codebase.
Hah! I refrained on suggesting the opposite at the last patch.
In older code there are lots of "puts", c.f. "git grep puts", so I assumed
it to be a micro optimization, hence I would have suggested it.
Either way is fine with me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help