Thread (1 message) 1 message, 1 author, 2017-07-31

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

From: Junio C Hamano <hidden>
Date: 2017-07-31 20:34:49

Stefan Beller [off-list ref] writes:
quoted
Further, remove duplicated space character.
https://en.wikipedia.org/wiki/Sentence_spacing
seems like a globally controversial thing. (I assumed
it was some sort of local dialect before researching
it properly)

I personally do not mind one way or another regarding
(double) spaces after a period, but I would think we'd
strive for consistency throughout the project.
I am not sure if that is something we want to encourage newbies to
be doing.  Especially a patch like this (notice the double-space
before "Go back to..." in the pre-context) makes me feel it is
distracting without adding much "consistency" value.

And no, I am not suggesting a tree-wide sweep to make everything
consistent.
quoted
      spend their time to improve your patch.  Go back to step (2).

  (4) The list forms consensus that the last round of your patch is
-     good.  Send it to the maintainer and cc the list.
+     good. Send it to the maintainer and cc the list.

  (5) A topic branch is created with the patch and is merged to 'next',
      and cooked further and eventually graduates to 'master'.
--
2.14.0.rc1.434.g6eded367a
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help