Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
From: Stefan Beller <hidden>
Date: 2017-07-31 20:23:30
On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam [off-list ref] wrote:
Replace the dashed version of a command with undashed version and quote it.
I like it, but similar as below, we'd want to go for consistency.
Further, remove duplicated space character.
https://en.wikipedia.org/wiki/Sentence_spacing seems like a globally controversial thing. (I assumed it was some sort of local dialect before researching it properly) I personally do not mind one way or another regarding (double) spaces after a period, but I would think we'd strive for consistency throughout the project.
quoted hunk ↗ jump to hunk
Signed-off-by: Kaartic Sivaraam <redacted> --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..9d0dab08d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches@@ -293,7 +293,7 @@ then you just add a line saying Signed-off-by: Random J Developer <random@developer.example.org> -This line can be automatically added by Git if you run the git-commit +This line can be automatically added by Git if you run the 'git commit' command with the -s option. Notice that you can place your own Signed-off-by: line when@@ -366,7 +366,7 @@ suggests to the contributors: spend their time to improve your patch. Go back to step (2). (4) The list forms consensus that the last round of your patch is - good. Send it to the maintainer and cc the list. + good. Send it to the maintainer and cc the list. (5) A topic branch is created with the patch and is merged to 'next', and cooked further and eventually graduates to 'master'. --2.14.0.rc1.434.g6eded367a