Re: [PATCH] Fix minor typo in git-diff docs.
From: Anthony Sottile <hidden>
Date: 2017-07-31 17:02:21
Thanks! I'll keep this in mind next time I send a patch. Anthony On Mon, Jul 31, 2017 at 9:59 AM, Junio C Hamano [off-list ref] wrote:
Anthony Sottile [off-list ref] writes:quoted
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt index 89cc0f4..43d18a4 100644 --- a/Documentation/diff-options.txt +++ b/Documentation/diff-options.txt@@ -392,7 +392,7 @@ endif::git-log[] the diff between the preimage and `/dev/null`. The resulting patch is not meant to be applied with `patch` or `git apply`; this is solely for people who want to just concentrate on reviewing the - text after the change. In addition, the output obviously lack + text after the change. In addition, the output obviously lacks enough information to apply such a patch in reverse, even manually, hence the name of the option. +Another thing that is more severe. You seem to have replaced all leading tabs with whitespaces, which makes the patch unusable. For this single character patch, I can pretend as if I applied your patch while making the fix myself in my editor, so there is no need to resend, but please make sure your e-mail client does not do that the next time. Thanks. Queued.