Thread (44 messages) 44 messages, 6 authors, 2017-07-29

Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

flat view

From: Stefan Beller <hidden>
Date: 2017-07-20 00:36:45

On Wed, Jul 19, 2017 at 5:21 PM, Jonathan Tan [off-list ref] wrote:
The "used" field in struct object is only used by builtin/fsck. Remove
that field and modify builtin/fsck to use a flag instead.
The patch looks good to me (I would even claim this could
go in as an independent cleanup, not tied to the RFCish nature
of the later patches), though I have a question:
How did you select 0x0008 for USED, i.e. does it
collide with other flags (theoretically?), and if so
how do we make sure to avoid the collusion in
the future?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help