Thread (57 messages) flat view 57 messages, 6 authors, 2017-08-02

Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'

From: Brandon Williams <hidden>
Date: 2017-07-12 18:54:18

On 07/11, Jacob Keller wrote:
On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams [off-list ref] wrote:
quoted
Convert grep to use 'struct repository' which enables recursing into
submodules to be handled in-process.

Signed-off-by: Brandon Williams <redacted>
---
 Documentation/git-grep.txt |   7 -
 builtin/grep.c             | 390 +++++++++------------------------------------
 cache.h                    |   1 -
 git.c                      |   2 +-
 grep.c                     |  13 --
 grep.h                     |   1 -
 setup.c                    |  12 +-
 7 files changed, 81 insertions(+), 345 deletions(-)
No real indepth comments here, but it's nice to see how much code
reduction this has enabled!
Yeah overall, with this and the ls-files conversion, I'm really pleased
with how much cleaner the code looks moving to working in-process.

-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help