[PATCH 2/4] hook: name the positional variables
flat view
STALE3349d
From: Kaartic Sivaraam <hidden>
Date: 2017-07-11 14:11:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2017-07-10 · Re: [PATCH 2/4] hook: name the positional variables · Junio C Hamano <hidden>
- 2017-07-10 · [PATCH 2/4] hook: name the positional variables · Kaartic Sivaraam <hidden>
It's always nice to have named variables instead of positional variables as they communicate their purpose well. Appropriately name the positional variables of the hook to make it easier to see what's going on. Signed-off-by: Kaartic Sivaraam <redacted> --- templates/hooks--prepare-commit-msg.sample | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/templates/hooks--prepare-commit-msg.sample b/templates/hooks--prepare-commit-msg.sample
index 279ddc1a7..eb5912163 100755
--- a/templates/hooks--prepare-commit-msg.sample
+++ b/templates/hooks--prepare-commit-msg.sample@@ -19,14 +19,17 @@ # The second example adds a Signed-off-by line to the message, that can # still be edited. This is rarely a good idea. +COMMIT_MSG_FILE=$1 +COMMIT_SOURCE=$2 +SHA1=$3 -# case "$2,$3" in +# case "$COMMIT_SOURCE,$SHA1" in # ,|template,) # @PERL_PATH@ -i.bak -pe ' # print "\n" . `git diff --cached --name-status -r` -# if /^#/ && $first++ == 0' "$1" ;; +# if /^#/ && $first++ == 0' "$COMMIT_MSG_FILE" ;; # *) ;; # esac # SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') -# grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" +# grep -qs "^$SOB" "$COMMIT_MSG_FILE" || echo "$SOB" >> "$COMMIT_MSG_FILE"
--
2.13.2.957.g457671ade