Re: [PATCH 3/7] git.c: provide setup_auto_pager()

From
Martin Ågren <hidden>
Date
2017-07-11 13:47:56
Reply to
Jeff King, 2017-07-11
On 11 July 2017 at 12:37, Jeff King [off-list ref] wrote:
On Mon, Jul 10, 2017 at 11:55:16PM +0200, Martin Ågren wrote:
quoted
+void setup_auto_pager(const char *cmd, int def)
+{
+     if (use_pager != -1)
+             return;
I think you probably also want to return early here if pager_in_use()
is true. If a script runs "git tag -l", you wouldn't want to start a new
pager when the outer script has already been paged (either via config,
or via "git -p").
Good point. Thanks.

Martin
Thread (50 messages) 50 messages, 3 authors, last reply 2017-08-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help