Re: [PATCH] strbuf: use designated initializers in STRBUF_INIT

On Mon, Jul 10, 2017 at 05:07:43PM -0700, Stefan Beller wrote:

On Mon, Jul 10, 2017 at 5:05 PM, brian m. carlson
[off-list ref] wrote:

quoted

On Mon, Jul 10, 2017 at 09:57:40PM +0200, Johannes Sixt wrote:

quoted

It's a pity, though, that you do not suggest something even more useful,
such as C++14.

I have tried compiling Git with a C++ compiler, so that I could test
whether that was a viable alternative for MSVC in case its C++ mode
supported features its C mode did not.  Let's just say that the
compilation aborted very quickly and I gave up after a few minutes.

... because we use reserved C++ keywords such as 'new' as variable names?

Yes, that was part of it ("template" stuck out to me).  I don't remember
all the issues, but they seemed quite numerous.  I'm sure it can be
done, though, if it's valuable to someone.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204