Thread (14 messages) flat view 14 messages, 3 authors, 2017-07-10

Re: [GSoC][PATCH 1/8] submodule--helper: introduce get_submodule_displaypath()

From: Stefan Beller <hidden>
Date: 2017-07-10 23:39:01

On Mon, Jul 10, 2017 at 4:32 PM, Brandon Williams [off-list ref] wrote:
quoted
      if (!is_submodule_active(the_repository, path)) {
-             strbuf_reset(&sb);
Is this line removal intended?  It doesn't look related to the rest of
this patch.
It is, as &sb is re-used and has to be cleared first.
With the code above removed, &sb is unmodified since
struct strbuf sb = STRBUF_INIT; hence the removal is ok here.
It is related, but only when looking at the entirety of the code. :-/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help