Thread (3 messages) flat view 3 messages, 2 authors, 2017-07-08

Re: [PATCH] apply: use strcmp(3) for comparing strings in gitdiff_verify_name()

From: René Scharfe <hidden>
Date: 2017-07-08 11:52:32

Am 08.07.2017 um 13:08 schrieb Ramsay Jones:
On 08/07/17 09:58, René Scharfe wrote:
quoted
Avoid running over the end of another -- a C string whose length we
don't know -- by using strcmp(3) instead of memcmp(3) for comparing it
with another C string.
I had to read this twice, along with the patch text, before this
made any sense. ;-) The missing information being that 'another'
was the name of the string variable that we were potentially
'running over the end of'.
Yeah, sorry, encasing that unusual variable name in quotes would
probably have helped.

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help