Re: [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol

2 messages, 2 authors, 2017-06-29 · open the first message on its own page

Re: [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol

From: Junio C Hamano <hidden>
Date: 2017-06-29 18:34:58

You seem to have squashed an unrelated "table-driven" clean-up into
this step.  While I think the end result looks good, I would have
liked to see it as a separate step, either as a preparatory "now we
are going to add the third one, let's make it table-driven before
doing so" step, or a follow-up "now we have done everything we
wanted to do, let's make this clean-up at the end" step.

Thanks.

Re: [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol

From: Lars Schneider <hidden>
Date: 2017-06-29 18:46:28

On 29 Jun 2017, at 20:34, Junio C Hamano [off-list ref] wrote:

You seem to have squashed an unrelated "table-driven" clean-up into
this step.  While I think the end result looks good, I would have
liked to see it as a separate step, either as a preparatory "now we
are going to add the third one, let's make it table-driven before
doing so" step, or a follow-up "now we have done everything we
wanted to do, let's make this clean-up at the end" step.
I am sorry. That was a misunderstanding - I thought you want to have 
this change squashed. 

The "preparatory" patch sounds good! 
Would you be OK if I send a v9 with this change?

Thanks,
Lars
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help