Thread (1 message) 1 message, 1 author, 2017-06-21

Re: [PATCH v4 0/8] Improvements to sha1_file

From: Junio C Hamano <hidden>
Date: 2017-06-21 18:18:41

Jonathan Tan [off-list ref] writes:
Thanks, Peff and Junio for your comments. Here's an updated version and
...
Jonathan Tan (8):
  sha1_file: teach packed_object_info about typename
  sha1_file: rename LOOKUP_UNKNOWN_OBJECT
  sha1_file: rename LOOKUP_REPLACE_OBJECT
  sha1_file: move delta base cache code up
  sha1_file: refactor read_object
  sha1_file: improve sha1_object_info_extended
  sha1_file: do not access pack if unneeded
  sha1_file: refactor has_sha1_file_with_flags
If 3/8 came before 2/8 I wouldn't have been puzzled by the latter,
and I threw comments at a few minor details but overall I didn't see
anything glaringly wrong that require a major rewrite of the series.

Overall it was a very pleasant read.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help