Thread (6 messages) flat view 6 messages, 2 authors, 2017-06-19

Re: [PATCH] mergetools/meld: improve backwards-compatibiilty when using "--output"

From: David Aguilar <hidden>
Date: 2017-06-18 07:46:13

On Sat, Jun 17, 2017 at 10:11:36AM -0400, Samuel Lijin wrote:
On Sat, Jun 17, 2017 at 6:24 AM, David Aguilar [off-list ref] wrote:
quoted
Meld 3.16.0 requires a "=" in the --output argument, as it uses
a simple hand-rolled command-line parser.

Newer versions of Meld (3.16.4, and possibly earlier) use
optpaarse, which accepts either "--output <file>" or
"--output=<file>".
Junio, there's an optpaarse -> optparse typo in the commit message
here in case you want to fix that up.
Do older versions also support both?
No.  When the "--output" option was first added (3.16.0, or possibly
earlier) it used the simpler parser that does not undertand the
"--output <filename>" form.

Much older versions didn't support "--output" at all, so we don't have
to worry about them since we already use the "--output" flag
selectively based on whether or not it's supported.
-- 
David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help