Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL()
From: Junio C Hamano <hidden>
Date: 2017-06-16 19:44:01
Possibly related (same subject, not in this thread)
- 2017-06-28 · Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL() · Junio C Hamano <hidden>
- 2017-06-28 · Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL() · Ævar Arnfjörð Bjarmason <hidden>
- 2017-06-28 · Re: [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL() · Junio C Hamano <hidden>
- 2017-06-15 · [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL() · Ævar Arnfjörð Bjarmason <hidden>
Ævar Arnfjörð Bjarmason [off-list ref] writes:
A follow-up to the existing "type" rule added in an earlier change. This catches some occurrences that are missed by the previous rule. Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> ---
Hmph, I wonder if the "type" thing is really needed. Over there, "ptr" is an expression and we can find "free(ptr); ptr = NULL" with the rule in this patch already, no? In any case, I'll queue these patches as-is. Thanks for working on this.
quoted hunk
contrib/coccinelle/free.cocci | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/contrib/coccinelle/free.cocci b/contrib/coccinelle/free.cocci index 35fb992621..f2d97e755b 100644 --- a/contrib/coccinelle/free.cocci +++ b/contrib/coccinelle/free.cocci@@ -17,3 +17,10 @@ T *ptr; - free(ptr); - ptr = NULL; + FREE_AND_NULL(ptr); + +@@ +expression E; +@@ +- free(E); +- E = NULL; ++ FREE_AND_NULL(E);