Thread (1 message) 1 message, 1 author, 2017-06-15

Re: [PATCH 1/2] for_each_bisect_ref(): don't trim refnames

From: Junio C Hamano <hidden>
Date: 2017-06-15 22:26:51

Michael Haggerty [off-list ref] writes:
`for_each_bisect_ref()` is called by `for_each_bad_bisect_ref()` with
a term "bad". This used to make it call `for_each_ref_in_submodule()`
with a prefix "refs/bisect/bad". But the latter is the name of the
reference that is being sought, so the empty string was being passed
to the callback as the trimmed refname. Moreover, this questionable
practice was turned into an error by

    b9c8e7f2fb prefix_ref_iterator: don't trim too much, 2017-05-22

It makes more sense (and agrees better with the documentation of
`--bisect`) for the callers to receive the full reference names. So

* Add a new function, `for_each_fullref_in_submodule()`, to the refs
  API.

* Change `for_each_bad_bisect_ref()` to call the new function rather
  than `for_each_ref_in_submodule()`.
This unfortunately makes nd/prune-in-worktree topic rather
obsolete.  Can somebody volunteer to update it to newer codebase
including this fix?

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help