Thread (1 message) 1 message, 1 author, 2017-06-15

Re: [PATCH v1] Configure Git contribution guidelines for github.com

From: Junio C Hamano <hidden>
Date: 2017-06-15 17:59:21

Andreas Heiduk [off-list ref] writes:
Am 15.06.2017 um 18:43 schrieb Junio C Hamano:
quoted
Another thing that may regress that you did not mention is that we
would lose a convenient way to _count_ proposed changes coming via
submitGit (i.e. you can simply go to the pull-request page), so that
the number can be compared with the number of proposed changes
directly made on the mailing list, which would be a good way to
gauge how submitGit service is helping our community.  But even for
that, you'd need to go to the list to find the denominator
(i.e. total number of changes proposed), and by the time you do
that, counting the numerator (i.e. those come via submitGit) by
finding the telltale sign submitGit leaves in its output among these
denominator messages should be trivial.
This numbers can be aquired quite easily if submitGit adds a defined
trailer to the converted commit message like this:

	Signed-off-by: Foo Bar <foo@bar>
	Submit-git-id: url-or-id-of-pr
I do not think you would want the noise _in_ the log message.  The
"telltale sign" I had in mind was these "signature" lines at the end
of the message:

    --
    https://github.com/git/git/pull/538
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help