Thread (4 messages) flat view 4 messages, 2 authors, 2017-07-26

Re: [RFC/PATCH] builtin/blame: darken redundant line information

From: Jonathan Tan <hidden>
Date: 2017-06-13 23:43:06

On Mon, 12 Jun 2017 19:31:51 -0700
Stefan Beller [off-list ref] wrote:
When using git-blame lots of lines contain redundant information, for
example in hunks that consist of multiple lines, the metadata (commit name,
author, timezone) are repeated. A reader may not be interested in those,
so darken them. The darkening is not just based on hunk, but actually
takes the previous lines content for that field to compare to.

Signed-off-by: Stefan Beller <redacted>
---

 Example output (blame of blame): http://i.imgur.com/0Y12p2f.png
Looking at this image, how does blame decide what to dim? As it is, I see many
identical timestamps (and also from the same commit) not being dimmed.
(For example, see the very last line with "2013-01-05 ..." which is
identical to the previous line, and I would expect that to be dimmed.)

Also, my preference is to have all-or-nothing dimming (dim the whole
line up to and including the time zone if nothing has changed, and dim
nothing otherwise) but I know that this is a subjective issue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help