Thread (17 messages) flat view 17 messages, 3 authors, 2017-06-15

Re: [PATCH 2/2] t: move "git add submodule" into test blocks

From: Stefan Beller <hidden>
Date: 2017-06-13 17:15:50

On Tue, Jun 13, 2017 at 2:24 AM, Jeff King [off-list ref] wrote:
Some submodule tests do some setup outside of a test_expect
block. This is bad because we won't actually check the
outcome of those commands. But it's doubly so because "git
add submodule" now produces a warning to stderr, which is
not suppressed by the test scripts in non-verbose mode.
Makes sense.
This patch does the minimal to fix the annoying warnings.
All three of these scripts could use more cleanup of related
setup.
agreed.
Signed-off-by: Jeff King <redacted>
Reviewed-by: Stefan Beller <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help