Thread (1 message) 1 message, 1 author, 2017-06-13

Re: [PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

From: Junio C Hamano <hidden>
Date: 2017-06-13 12:59:24

Johannes Schindelin [off-list ref] writes:
Sadly, I do not think so. It is just different, not better. Maybe less
redundant... See for yourself:
Yup, I noticed and was referring to this "less redundant" as an
improvement, actually.
The real fix would indeed be (as mentioned by Brandon elsewhere) to unify
the code paths between the cached and the non-cached config machinery, so
as to provide the exact same error message in this case.
Yeah, the unifying of the messages would be a good addition in the
mid term but I tend to agree that it can be done after this series
lands.

Thanks for clarification.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help