Re: [PATCH] wildmatch test: cover a blind spot in "/" matching
From: Junio C Hamano <hidden>
Date: 2017-06-10 01:55:39
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Add a test which covers a blindspot in how these tests should assert that negated character classes are allowed or not allowed to match "/" in certain circumstances.
Please make this a bit more explicit, something like
A negated character class that does not include '/',
e.g. [^a-z],
- should match '/' when doing "wildmatch"
- should not match '/' when doing "pathmatch"
Add two tests to cover these cases.
Thanks.
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t3070-wildmatch.sh | 2 ++ 1 file changed, 2 insertions(+)diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh index ef509df35160..65ea07b68356 100755 --- a/t/t3070-wildmatch.sh +++ b/t/t3070-wildmatch.sh@@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar' match 1 0 'foo/bar' 'foo/**/**/bar' match 0 0 'foo/bar' 'foo?bar' match 0 0 'foo/bar' 'foo[/]bar' +match 0 0 'foo/bar' 'foo[^a-z]bar' match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r' match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r' match 1 0 'foo' '**/foo'@@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z' pathmatch 0 foo/bba/arr 'foo/**z' pathmatch 1 foo/bar 'foo?bar' pathmatch 1 foo/bar 'foo[/]bar' +pathmatch 1 foo/bar 'foo[^a-z]bar' pathmatch 0 foo '*/*/*' pathmatch 0 foo/bar '*/*/*' pathmatch 1 foo/bba/arr '*/*/*' --https://github.com/git/git/pull/362