Thread (2 messages) flat view 2 messages, 2 authors, 2017-06-08

Re: [PATCH] docs: suggest "Helped-by" rather than "Thanks-to"

From: Adam Dinwoodie <hidden>
Date: 2017-06-08 08:44:04

(Resending to everyone after only sending to Junio by mistake.)

On Wed, Jun 07, 2017 at 08:44:08AM +0900, Junio C Hamano wrote:
Adam Dinwoodie [off-list ref] writes:
quoted
On Mon, Jun 05, 2017 at 11:42:31AM -0700, Stefan Beller wrote:
quoted
So I was wondering if there is a command that shows all trailers?
Similar to a "shortlog -sne" I would want to have a list of all trailers.
This is because there might be an even more popular trailer than
"Helped-by", but we would not know when using the hack above.

While I do not think so, it would sure be interesting to have a list
of all these trailers available.
I just did a quick search with the following knocked-together command:

    git log --remotes --format=format:%B | sed -rn 's/^([A-Za-z0-9-]+): .* <.*@.*>.*/\1/p' | sort | uniq -c | sort -nr

The top 10 such tags according to this (which is coincidentally the same
list as the list of all tags used more than 100 times), with
frequencies, are:

  61535 Signed-off-by
   1641 Acked-by
    984 Reviewed-by
    673 Helped-by
    497 Reported-by
    180 Cc
    174 Suggested-by
    159 Tested-by
    158 Mentored-by
    128 Noticed-by

As you might expect, there are a number of entertaining ones that have
only been used once or twice, such as "Looks-fine-to-me-by",
"Worriedly-Acked-by", "More-Spots-Found-By", "Looks-right-to-me-by",
"Hopefully-signed-off-by"...
Thanks for an interesting list.  Your replacing (totally
unconventional) Thanks-to with more common Helped-by is certainly an
improvement, but I wonder if we should encourage people to be
"original" in this area by having that "You can also invent"
paragraph in the first place.
I would expect we could never come up with a list that will cover every
possible scenario. I suppose the question is whether it's worse for
people to feel like it's encouraged to come up with non-standard options
or for them to feel they can't deviate from a given list if none of the
available options suits them.

And I definitely don't feel I have a good enough grasp of what these
lines are used for in practice to make any sort of informed comment, so
I shall leave it to people with more experience than I to propose the
patch or not.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help