Re: [GSoC] Update: Week 3

On Mon, Jun 5, 2017 at 1:56 PM, Prathamesh Chavan [off-list ref] wrote:

1. foreach: After a discussion over the issue of the path variable in
   windows, in this week my mentor, Stefan Beller came up with the
   appropriate solution for the problem after discussing it with Ramsay
   Jones.

Thanks for having so much faith in my abilities, but it may not be
appropriate, yet. (It does multiple things at once, which is generally
a bad sign already. )

Maybe to be unblocked on the conversion of foreach, you could make
the patch have the original behavior, i.e.

<up_path><submodule path>

which makes sense in the way that it is only converting from shell to C,
not fixing a bug along the way. As we discovered a bug, you could just put
a NEEDSWORK comment explaining what the problem is; deferring solving
the issue until later.

I'll review the other patches.

Thanks,
Stefan