Re: [PATCH 30/33] tree-diff: convert diff_tree_paths to struct object_id
From: Junio C Hamano <hidden>
Date: 2017-06-02 01:31:14
Brandon Williams [off-list ref] writes:
quoted hunk
@@ -220,7 +221,7 @@ static struct combine_diff_path *emit_path(struct combine_diff_path *p, if (emitthis) { int keep; struct combine_diff_path *pprev = p; - p = path_appendnew(p, nparent, base, path, pathlen, mode, sha1); + p = path_appendnew(p, nparent, base, path, pathlen, mode, oid ? oid->hash : NULL);
This is a correct conversion, but it shows that "struct oid" that has "hash" sometimes makes things a bit cumbersome. Perhaps path_appendnew() and friends need to learn to take a pointer to "struct oid" next.