Thread (2 messages) flat view 2 messages, 2 authors, 2017-05-30

Re: [PATCH v3 13/13] is_missing_file_error(): work around EINVAL on Windows

From: Junio C Hamano <hidden>
Date: 2017-05-30 23:17:20

Stefan Beller [off-list ref] writes:
On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano [off-list ref] wrote:
quoted
When asked to open/fopen a path, e.g. "a/b:/c", which does not exist
on the filesystem, Windows (correctly) fails to open it but sets
EINVAL to errno
errno to EINVAL (as of now it sounds as if it is a EINVAL = errno,
which makes no sense to me)
quoted
because the pathname has characters that cannot be
stored in its filesystem.

As this is an expected failure, teach is_missing_file_error() helper
about this case.

This is RFC,
cc'd people knowledgeable of Windows.
This has been resolved I think with J6t/Dscho's patch yesterday.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help